Stefan/merlin_env_helper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update Doc & Fallback improvement

Browse Source
This commit is contained in:
Stefan Menner
2025-06-22 16:49:54 +02:00
parent 4369d9209d
commit ee6b992c8e
3 changed files with 96 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Cargo.lock generated
View File

@@ -4,4 +4,4 @@ version = 4
[[package]]
name = "merlin_env_helper"
version = "0.3.0"
version = "0.4.0"

2
Cargo.toml
View File

@@ -1,6 +1,6 @@
[package]
name = "merlin_env_helper"
version = "0.3.0"
version = "0.4.0"
edition = "2024"
publish = ["merlin"]
description = "Utility functions to read environment with fallback and values from a file"

99
src/config/env.rs
View File

@@ -30,13 +30,17 @@
//! }
//! ```
use core::fmt;
use std::{error::Error, fmt::{Display, Formatter}, io::{self, Read}, path::Path};
use std::{
error::Error,
fmt::{Display, Formatter},
io::{self, Read},
path::Path,
};
use crate::config::types::EnvKey;
pub type Result<T, E = ConfigError> = std::result::Result<T, E>;
#[derive(Debug)]
#[non_exhaustive]
pub struct ConfigError {
@@ -60,7 +64,6 @@ impl Error for ConfigError {
}
}
/// The kind of error that can occur when reading a configuration key.
#[derive(Debug)]
pub enum ConfigErrorKind {
@@ -82,17 +85,26 @@ impl Display for ConfigErrorMessage {
}
}
impl Error for ConfigErrorMessage {
}
impl Error for ConfigErrorMessage {}
pub fn get_env_value(env_key : &EnvKey) -> Result<String> {
/// Retrieves the value of an environment variable or a secure file-based secret.
/// If not specified, a fallback value is returned if one is specified, otherwise an error is returned.
pub fn get_env_value(env_key: &EnvKey) -> Result<String> {
if let Some(sec_key) = &env_key.sec_key {
let key = std::env::var(&sec_key);
if let Ok(path_file) = key {
return read_secure_value(&env_key.key, &path_file);
let result = read_secure_value(&env_key.key, &path_file);
if let Ok(value) = result {
return Ok(value);
}
if let Some(fallback) = &env_key.fallback {
return Ok(fallback.to_string());
}
return result;
}
}
@@ -102,7 +114,6 @@ pub fn get_env_value(env_key : &EnvKey) -> Result<String> {
fn read_key_value(key: &str, fallback: &Option<String>) -> Result<String> {
let env_value = std::env::var(key);
println!("env_value: {:?}", env_value);
if let Ok(value) = env_value {
return Ok(value);
}
@@ -111,21 +122,16 @@ fn read_key_value(key: &str, fallback: &Option<String>) -> Result<String> {
return Ok(fallback.to_string());
}
Err(
ConfigError {
Err(ConfigError {
key: key.to_string(),
kind: ConfigErrorKind::NotFound,
}
)
})
}
fn read_secure_value(key: &str, path_file: &str) -> Result<String> {
let path = Path::new(path_file);
let exists = path.try_exists().map_err(|e| -> ConfigError {
println!("path.try_exists(): {:?}", e);
ConfigError {
key: format!("{}: {} File not found.", key.to_string(), path_file),
kind: ConfigErrorKind::IO(e),
@@ -133,18 +139,15 @@ fn read_secure_value(key: &str, path_file: &str) -> Result<String> {
})?;
if !exists {
return Err(
ConfigError {
return Err(ConfigError {
key: format!("{}: {} File not found.", key.to_string(), path_file),
kind: ConfigErrorKind::FileNotFound(ConfigErrorMessage {
msg: format!("File not found: {}", path_file),
}),
}
);
});
}
let file = std::fs::File::open(path).map_err(|e| -> ConfigError {
println!("std::fs::File::open(path_file): {:?}", e);
ConfigError {
key: key.to_string(),
kind: ConfigErrorKind::IO(e),
@@ -154,7 +157,9 @@ fn read_secure_value(key: &str, path_file: &str) -> Result<String> {
let mut reader = std::io::BufReader::new(file);
let mut content = String::new();
reader.read_to_string(&mut content).map_err(|e| -> ConfigError {
reader
.read_to_string(&mut content)
.map_err(|e| -> ConfigError {
ConfigError {
key: key.to_string(),
kind: ConfigErrorKind::IO(e),
@@ -164,7 +169,6 @@ fn read_secure_value(key: &str, path_file: &str) -> Result<String> {
Ok(content)
}
#[cfg(test)]
mod tests {
use super::*;
@@ -172,24 +176,25 @@ mod tests {
fn clean_up(reset_value: &Option<String>) {
if let Some(value) = reset_value {
unsafe {std::env::set_var("TEST_KEY", value)};
unsafe { std::env::set_var("TEST_KEY", value) };
} else {
unsafe {std::env::remove_var("TEST_KEY")};
unsafe { std::env::remove_var("TEST_KEY") };
}
}
fn run_test<T, U>(env_key : &str, test: T, clean_up: U) -> ()
where T: FnOnce() -> () + std::panic::UnwindSafe
, U: FnOnce(&Option<String>) -> ()
fn run_test<T, U>(env_key: &str, test: T, clean_up: U) -> ()
where
T: FnOnce() -> () + std::panic::UnwindSafe,
U: FnOnce(&Option<String>) -> (),
{
let old_value = std::env::var(env_key);
let mut reset_value= None;
let mut reset_value = None;
if let Ok(value) = old_value {
reset_value = Some(value.clone());
}
let result = panic::catch_unwind( || {
let result = panic::catch_unwind(|| {
test();
});
@@ -200,25 +205,26 @@ mod tests {
#[test]
fn test_get_env_value() {
run_test("TEST_KEY", || {
run_test(
"TEST_KEY",
|| {
let key = "TEST_KEY";
let value = "test_value";
unsafe {std::env::set_var(key, value)};
unsafe { std::env::set_var(key, value) };
let env_key = EnvKey::key(key);
let result = get_env_value(&env_key);
assert_eq!(result.is_ok(), true);
assert_eq!(result.unwrap(), value);
},
clean_up
clean_up,
);
}
#[test]
fn test_get_env_value_with_fallback() {
run_test("TEST_KEY", || {
run_test(
"TEST_KEY",
|| {
let key = "TEST_KEY";
let fallback_value = "fallback_value";
@@ -227,19 +233,23 @@ mod tests {
assert_eq!(result.is_ok(), true);
assert_eq!(result.unwrap(), fallback_value);
},
clean_up);
clean_up,
);
}
#[test]
fn test_get_env_value_with_secure_key() {
run_test("TEST_KEY", || {
run_test(
"TEST_KEY",
|| {
let key = "TEST_KEY";
let value = "test_value";
let secure_key = "TEST_KEY_FILE";
let secure_value = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("resources/test/test_secret.txt");
let secure_value = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
.join("resources/test/test_secret.txt");
unsafe {std::env::set_var(key, value)};
unsafe {std::env::set_var(secure_key, &secure_value)};
unsafe { std::env::set_var(key, value) };
unsafe { std::env::set_var(secure_key, &secure_value) };
assert_eq!(secure_value.try_exists().unwrap(), true);
@@ -248,6 +258,7 @@ mod tests {
assert_eq!(result.is_ok(), true);
assert_eq!(result.unwrap(), "my_secret");
},
clean_up);
clean_up,
);
}
}